adding OPEN_TREE_NAMESPACE and fsopen/fsconfig/fsmount/fspick constan…#5145
Merged
Conversation
devnexen
force-pushed
the
linux-new-mount-api
branch
from
bb7dfff to
7957b2b
Compare
This comment has been minimized.
This comment has been minimized.
devnexen
force-pushed
the
linux-new-mount-api
branch
from
7957b2b to
19d0872
Compare
This comment has been minimized.
This comment has been minimized.
tgross35
requested changes
Jun 19, 2026
Comment on lines
+4187
to
+4192
| // FIXME(linux): Requires newer kernel headers than CI has, even on glibc, | ||
| // so skip on every libc until CI catches up. OPEN_TREE_NAMESPACE landed in | ||
| // v7.0, FSCONFIG_CMD_CREATE_EXCL in v6.6. | ||
| if name == "OPEN_TREE_NAMESPACE" || name == "FSCONFIG_CMD_CREATE_EXCL" { | ||
| return true; | ||
| } |
Contributor
There was a problem hiding this comment.
I think we should have these now, CI was recently updated to something with 7.0
Contributor
Author
There was a problem hiding this comment.
unfortunately I had to put it back still some lower tiers run old kernels.
Comment on lines
+3121
to
+3130
| // enum fsconfig_command | ||
| pub const FSCONFIG_SET_FLAG: c_uint = 0; | ||
| pub const FSCONFIG_SET_STRING: c_uint = 1; | ||
| pub const FSCONFIG_SET_BINARY: c_uint = 2; | ||
| pub const FSCONFIG_SET_PATH: c_uint = 3; | ||
| pub const FSCONFIG_SET_PATH_EMPTY: c_uint = 4; | ||
| pub const FSCONFIG_SET_FD: c_uint = 5; | ||
| pub const FSCONFIG_CMD_CREATE: c_uint = 6; | ||
| pub const FSCONFIG_CMD_RECONFIGURE: c_uint = 7; | ||
| pub const FSCONFIG_CMD_CREATE_EXCL: c_uint = 8; |
Contributor
There was a problem hiding this comment.
Can you use c_enum!?
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
devnexen
force-pushed
the
linux-new-mount-api
branch
from
19d0872 to
066bb63
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
devnexen
force-pushed
the
linux-new-mount-api
branch
from
066bb63 to
8970d05
Compare
devnexen
force-pushed
the
linux-new-mount-api
branch
from
8970d05 to
3be48b4
Compare
Contributor
Author
|
@rustbot ready |
tgross35
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ts for Linux (7.0)
Close #5072
ref
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI